Unconditional do_probe_raise() in probe_pt() #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Z_RAISE_BETWEEN_PROBINGS is null or undefined the probe is currently not raised by home_offset[Z_AXIS] and zprobe_zoffset. But when different from 0 is. If an undefined Z_RAISE_BETWEEN_PROBINGS expands to 0 (and it does) this is the solution. A similar asymmetry exists with the newly introduced 'short-cut' in G28 - but its the rise before anything is probed - so should not make a difference.
|
@AnHardt This may only be covering up a bug, I think. For one thing we do not want anything "raised by Is this already considered here? I can see that skipping the raise would be a problem for a positive |
Closed
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
May 31, 2024
MBL print area
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
May 31, 2024
Clean up mesh definitions that where made obsolete by MarlinFirmware#4183
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
May 31, 2024
drewmoseley
pushed a commit
to drewmoseley/Marlin
that referenced
this pull request
May 31, 2024
…area_translations 🚧 Add new MBL message for MarlinFirmware#4183 and translation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
Z_RAISE_BETWEEN_PROBINGSis null or undefined the probe is currently not raised byhome_offset[Z_AXIS]andzprobe_zoffset. But when the smallest bit different from 0 it is.If an undefined
Z_RAISE_BETWEEN_PROBINGSexpands to 0 (and it does) this is the solution.A similar asymmetry exists with the newly introduced 'short-cut' in
G28- but it's the rise before anything is probed - so should not make a difference.This asymmetry likely causes the effects in #4177